From: Paul Tarjan <paul@paultarjan.com>
Date: Sat, 28 Feb 2026 17:33:14 GMT
Subject: Re: [PATCH] fsmonitor-watchman: fix variable reference and remove redundant code
Message-ID: <20260228173314.97952-1-github@paulisageek.com>
In-Reply-To: <CAOTNsDyy2ZQDhkVyML6j5naS_UC=SjE915hjygj+QmKe4bqc=A@mail.gmail.com>

Koji Nakamaru <koji.nakamaru@gree.net> writes:

> Although I don't have much experience with the Watchman backend, the
> fixes look correct to me.
>
> One suggestion: it seems we can make the code even cleaner by removing
> $retry and its associated logic, as they appear to be no longer
> necessary after these changes.

Good point. $retry only existed to prevent the infinite recursion
from the recursive launch_watchman() call, so now that we've
removed that call it's dead code. Cleaned it up in v2.

Thanks for the review,
Paul