git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fsmonitor-watchman: fix variable reference and remove redundant code

From
PTPaul Tarjan <paul@paultarjan.com>
Date
Feb 28, 2026, 17:33 UTC
Message-ID
<20260228173310.97905-1-github@paulisageek.com>
In-Reply-To
<aaMiu9mDVAb6Qvyr@fruit.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> This looks like it was written by an LLM.  Is that the case, and if so,
> how does it line up with https://git-scm.com/docs/SubmittingPatches#ai?

I found these bugs during code review at my company where we use the watchman hook. The $output vs $o mixup and the double output_result() from the recursive call were both causing real issues. I used Claude to help with the mechanics of formatting and submitting the patch, and it ended up as the commit author, which was a mistake on my part. I'll fix that in v2 with myself as the author.

Thanks for flagging it, Paul

Previous: brian m. carlsonNext: Paul Tarjan via GitGitGadget
Message 7 of 8 in “fsmonitor: fix two bugs in watchman hook retry path”
  1. fsmonitor: fix two bugs in watchman hook retry pathPaul Tarjan via GitGitGadget, Jan 26, 2026
  2. Paul TarjanFeb 8, 2026
  3. Paul TarjanFeb 27, 2026
  4. Koji NakamaruFeb 28, 2026
  5. Paul TarjanFeb 28, 2026
  6. brian m. carlsonFeb 28, 2026
  7. Paul TarjanFeb 28, 2026
  8. fsmonitor-watchman: fix variable reference and remove redundant codePaul Tarjan via GitGitGadget, Feb 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.