git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t5500-fetch-pack.sh and exit-code suppression

From
Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
Date
Jan 12, 2026, 09:11 UTC
Message-ID
<20260112091151.309268-1-shreyanshpaliwalcmsmn@gmail.com>
In-Reply-To
<aWSv8dlt32xg14e1@pks.im>
Show 16 quoted lines
> Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> writes:
> > >	GIT_PROTOCOL=version=2 git upload-pack . <<-EOF >/dev/null
> > >	0012command=fetch
> > > -	$(echo "object-format=$(test_oid algo)" | packetize)
> > > +	$(echo "object-format=$(<oid_algo)" | packetize)
> > 
> > The construct $(<file) is bashism, that does not work if your shell
> > is not bash, isn't it?  If you used a variable, e.g.,
> > 
> >	$(echo "object-format=$oid_algo" | packetize)
> > 
> > that would make the result more portable.
>
> There's no need for the echo at all as this can also be written as:
>
>    packetize "object-format=$oid_algo"

Yes, that would I believe avoid the pipe entirely and therefore remove the exit-code suppression issue altogether.

Best, Shreyansh

Previous: Patrick SteinhardtNext: Junio C Hamano
Message 4 of 12 in “t5500-fetch-pack.sh: fix suppression of Git exit code in tests”
  1. t5500-fetch-pack.sh: fix suppression of Git exit code in testsShreyansh Paliwal, Jan 11, 2026
  2. Junio C HamanoJan 11, 2026
  3. Patrick SteinhardtJan 12, 2026
  4. Shreyansh PaliwalJan 12, 2026
  5. Junio C HamanoJan 12, 2026
  6. Shreyansh PaliwalJan 13, 2026
  7. Junio C HamanoJan 13, 2026
  8. [GSOC][PATCH] t5500: simplify test implementation and fix git exit code suppressionShreyansh Paliwal, Jan 13, 2026
  9. Shreyansh PaliwalJan 15, 2026
  10. Junio C HamanoJan 20, 2026
  11. [GSOC][PATCH V2] t5500: simplify test implementation and fix git exit code suppressionShreyansh Paliwal, Jan 21, 2026
  12. t5500-fetch-pack.sh: fix suppression of Git exit code in testsShreyansh Paliwal, Jan 12, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.