[RFC PATCH] t5500-fetch-pack.sh: fix suppression of Git exit code in tests
- From
Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
- Date
- Jan 11, 2026, 20:00 UTC
- Message-ID
- <20260111202137.257405-1-shreyanshpaliwalcmsmn@gmail.com>
Hello,
While implementing the Avoid suppressing Git exit code in test scripts microproject for GSoC, I tried to modify this test to remove this suppression. However, after making the changes I ran the make test command to check, and the test #365 in which I made changes is failing.
Could someone please explain why this test might be failing after such a change, is it something I am missing or is there something that makes this test not amendable directly?
P.S. Kindly ignore the commit message or format, this is only meant to discuss the failing test before the actual commit.
Best, Shreyansh
Signed-off-by: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> --- t/t5500-fetch-pack.sh | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/t/t5500-fetch-pack.sh b/t/t5500-fetch-pack.sh index 2677cd5faa..1ae2d41c47 100755 --- a/t/t5500-fetch-pack.sh +++ b/t/t5500-fetch-pack.sh @@ -892,13 +892,16 @@ test_expect_success 'shallow since with commit graph and already-seen commit' ' test_commit other && git commit-graph write --reachable && git config core.commitGraph true && + test_oid algo >oid_algo && + git rev-parse other >oid_other && + git rev-parse main >oid_main && GIT_PROTOCOL=version=2 git upload-pack . <<-EOF >/dev/null 0012command=fetch - $(echo "object-format=$(test_oid algo)" | packetize) + $(echo "object-format=$(<oid_algo)" | packetize) 00010013deepen-since 1 - $(echo "want $(git rev-parse other)" | packetize) - $(echo "have $(git rev-parse main)" | packetize) + $(echo "want $(<oid_other)" | packetize) + $(echo "have $(<oid_main)" | packetize) 0000 EOF )
-- 2.43.0