From: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
Date: Mon, 12 Jan 2026 09:11:35 GMT
Subject: Re: t5500-fetch-pack.sh and exit-code suppression
Message-ID: <20260112091151.309268-1-shreyanshpaliwalcmsmn@gmail.com>
In-Reply-To: <aWSv8dlt32xg14e1@pks.im>

> Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> writes:
> > >	GIT_PROTOCOL=version=2 git upload-pack . <<-EOF >/dev/null
> > >	0012command=fetch
> > > -	$(echo "object-format=$(test_oid algo)" | packetize)
> > > +	$(echo "object-format=$(<oid_algo)" | packetize)
> > 
> > The construct $(<file) is bashism, that does not work if your shell
> > is not bash, isn't it?  If you used a variable, e.g.,
> > 
> >	$(echo "object-format=$oid_algo" | packetize)
> > 
> > that would make the result more portable.
>
> There's no need for the echo at all as this can also be written as:
>
>    packetize "object-format=$oid_algo"

Yes, that would I believe avoid the pipe entirely and therefore
remove the exit-code suppression issue altogether.

Best,
Shreyansh