git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 22/29] rebase: persist --trailer options across restarts

From
Li Chen <me@linux.beauty>
Date
Oct 22, 2025, 05:39 UTC
Message-ID
<20251022053951.602605-23-me@linux.beauty>
In-Reply-To
<20251022053951.602605-1-me@linux.beauty>

t3440 showed rebase -m loses trailers after conflicts. Each --continue spawns a fresh replay_opts without trailer_args. Serialize them into rebase-merge/trailer so new runs reload them. This keeps the user requested trailers intact when resuming.

Signed-off-by: Li Chen <chenl311@chinatelecom.cn>
---
 sequencer.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
diff --git a/sequencer.c b/sequencer.c
index 552e629e4f..c02364cfce 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -209,6 +209,7 @@ static GIT_PATH_FUNC(rebase_path_reschedule_failed_exec, "rebase-merge/reschedul
 static GIT_PATH_FUNC(rebase_path_no_reschedule_failed_exec, "rebase-merge/no-reschedule-failed-exec")
 static GIT_PATH_FUNC(rebase_path_drop_redundant_commits, "rebase-merge/drop_redundant_commits")
 static GIT_PATH_FUNC(rebase_path_keep_redundant_commits, "rebase-merge/keep_redundant_commits")
+static GIT_PATH_FUNC(rebase_path_trailer, "rebase-merge/trailer")
 
 /*
  * A 'struct replay_ctx' represents the private state of the sequencer.
@@ -3244,6 +3245,17 @@ static int read_populate_opts(struct replay_opts *opts)
 
 		read_strategy_opts(opts, &buf);
 		strbuf_reset(&buf);
+		if (strbuf_read_file(&buf, rebase_path_trailer(), 0) >= 0) {
+			char *p = buf.buf, *nl;
+
+			while ((nl = strchr(p, '\n'))) {
+				*nl = '\0';
+				if (*p)
+					strvec_push(&opts->trailer_args, p);
+				p = nl + 1;
+			}
+			strbuf_reset(&buf);
+		}
 
 		if (read_oneliner(&ctx->current_fixups,
 				  rebase_path_current_fixups(),
@@ -3338,6 +3350,14 @@ int write_basic_state(struct replay_opts *opts, const char *head_name,
 		write_file(rebase_path_reschedule_failed_exec(), "%s", "");
 	else
 		write_file(rebase_path_no_reschedule_failed_exec(), "%s", "");
+	if (opts->trailer_args.nr) {
+		struct strbuf buf = STRBUF_INIT;
+
+		for (size_t i = 0; i < opts->trailer_args.nr; i++)
+			strbuf_addf(&buf, "%s\n", opts->trailer_args.v[i]);
+		write_file(rebase_path_trailer(), "%s", buf.buf);
+		strbuf_release(&buf);
+	}
 
 	return 0;
 }
-- 
2.51.0
Previous: Li ChenNext: Li Chen
Message 26 of 33 in “rebase: support --trailer”
  1. 00/29 rebase: support --trailerLi Chen, Oct 22, 2025
  2. 01/29 trailer: append trailers in-process and drop the fork to `interpret-trailers`Li Chen, Oct 22, 2025
  3. Phillip WoodOct 23, 2025
  4. Li ChenNov 4, 2025
  5. 02/29 trailer: restore interpret_trailers helperLi Chen, Oct 22, 2025
  6. 03/29 trailer: drop --trailer prefix handling in amend helperLi Chen, Oct 22, 2025
  7. 04/29 trailer: move config_head and arg_head to if storageLi Chen, Oct 22, 2025
  8. 05/29 trailer: use bool for had_trailer_beforeLi Chen, Oct 22, 2025
  9. 06/29 interpret-trailers: buffer stdout outputLi Chen, Oct 22, 2025
  10. 07/29 trailer: mirror interpret-trailers output flowLi Chen, Oct 22, 2025
  11. 08/29 trailer: handle trailer append failures gentlyLi Chen, Oct 22, 2025
  12. 09/29 rebase: support --trailerLi Chen, Oct 22, 2025
  13. Phillip WoodOct 23, 2025
  14. 10/29 rebase: inline trailer state pathsLi Chen, Oct 22, 2025
  15. 11/29 rebase: reuse buffer for trailer argsLi Chen, Oct 22, 2025
  16. 12/29 rebase: drop redundant strbuf_release callLi Chen, Oct 22, 2025
  17. 13/29 rebase: skip stripping of --trailer option prefixLi Chen, Oct 22, 2025
  18. 14/29 rebase: die on invalid trailer argsLi Chen, Oct 22, 2025
  19. 15/29 rebase: validate trailers with configured separatorsLi Chen, Oct 22, 2025
  20. 16/29 sequencer: add trailers to message before writing fileLi Chen, Oct 22, 2025
  21. 17/29 t3440: create expect files at point of useLi Chen, Oct 22, 2025
  22. 18/29 t3440: check apply backend error includes optionLi Chen, Oct 22, 2025
  23. 19/29 t3440: use test_commit_message for trailer checksLi Chen, Oct 22, 2025
  24. 20/29 t3440: drop redundant resets and pass branch to rebase where neededLi Chen, Oct 22, 2025
  25. 21/29 t3440: assert trailer on HEAD after conflict rebaseLi Chen, Oct 22, 2025
  26. 22/29 rebase: persist --trailer options across restartsLi Chen, Oct 22, 2025
  27. 23/29 t3440: remove redundant --keep-emptyLi Chen, Oct 22, 2025
  28. 24/29 t3440: use helper for trailer checksLi Chen, Oct 22, 2025
  29. 25/29 t3440: test --trailer without valuesLi Chen, Oct 22, 2025
  30. 26/29 t3440: convert ex.com to example.comLi Chen, Oct 22, 2025
  31. 27/29 t3440: ensure trailers persist after rebase continueLi Chen, Oct 22, 2025
  32. 28/29 t3440: exercise trailer config mappingLi Chen, Oct 22, 2025
  33. 29/29 sequencer: honor --trailer with fixup -CLi Chen, Oct 22, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.