git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 19/29] t3440: use test_commit_message for trailer checks

From
Li Chen <me@linux.beauty>
Date
Oct 22, 2025, 05:39 UTC
Message-ID
<20251022053951.602605-20-me@linux.beauty>
In-Reply-To
<20251022053951.602605-1-me@linux.beauty>

Replaced the pipeline-based trailer assertions with explicit expectations verified by test_commit_message, ensuring the rebase trailer tests catch git command failures reliably.

Signed-off-by: Li Chen <chenl311@chinatelecom.cn>
---
 t/t3440-rebase-trailer.sh | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/t/t3440-rebase-trailer.sh b/t/t3440-rebase-trailer.sh
index 6b1c93b4cb..1571dd2c97 100755
--- a/t/t3440-rebase-trailer.sh
+++ b/t/t3440-rebase-trailer.sh
@@ -52,18 +52,28 @@ test_expect_success 'reject trailer with missing key before separator' '
 
 test_expect_success 'CLI trailer duplicates allowed; replace policy keeps last' '
 	git reset --hard third &&
-	git -c trailer.Bug.ifexists=replace -c trailer.Bug.ifmissing=add rebase -m --trailer "Bug: 123" --trailer "Bug: 456" HEAD~1 &&
-	git cat-file commit HEAD | grep "^Bug: 456" &&
-	git cat-file commit HEAD | grep -v "^Bug: 123"
+	git -c trailer.Bug.ifexists=replace -c trailer.Bug.ifmissing=add \
+		rebase -m --trailer "Bug: 123" --trailer "Bug: 456" HEAD~1 &&
+	cat >expect <<-\EOF &&
+	third
+
+	Bug: 456
+	EOF
+	test_commit_message HEAD expect
 '
 
 test_expect_success 'multiple Signed-off-by trailers all preserved' '
 	git reset --hard third &&
 	git rebase -m \
-		--trailer "Signed-off-by: Dev A <a@ex.com>" \
-		--trailer "Signed-off-by: Dev B <b@ex.com>" HEAD~1 &&
-	git cat-file commit HEAD | grep -c "^Signed-off-by:" >count &&
-	test "$(cat count)" = 2   # two new commits
+			--trailer "Signed-off-by: Dev A <a@ex.com>" \
+			--trailer "Signed-off-by: Dev B <b@ex.com>" HEAD~1 &&
+	cat >expect <<-\EOF &&
+	third
+
+	Signed-off-by: Dev A <a@ex.com>
+	Signed-off-by: Dev B <b@ex.com>
+	EOF
+	test_commit_message HEAD expect
 '
 
 test_expect_success 'rebase -m --trailer adds trailer after conflicts' '
-- 
2.51.0
Previous: Li ChenNext: Li Chen
Message 23 of 33 in “rebase: support --trailer”
  1. 00/29 rebase: support --trailerLi Chen, Oct 22, 2025
  2. 01/29 trailer: append trailers in-process and drop the fork to `interpret-trailers`Li Chen, Oct 22, 2025
  3. Phillip WoodOct 23, 2025
  4. Li ChenNov 4, 2025
  5. 02/29 trailer: restore interpret_trailers helperLi Chen, Oct 22, 2025
  6. 03/29 trailer: drop --trailer prefix handling in amend helperLi Chen, Oct 22, 2025
  7. 04/29 trailer: move config_head and arg_head to if storageLi Chen, Oct 22, 2025
  8. 05/29 trailer: use bool for had_trailer_beforeLi Chen, Oct 22, 2025
  9. 06/29 interpret-trailers: buffer stdout outputLi Chen, Oct 22, 2025
  10. 07/29 trailer: mirror interpret-trailers output flowLi Chen, Oct 22, 2025
  11. 08/29 trailer: handle trailer append failures gentlyLi Chen, Oct 22, 2025
  12. 09/29 rebase: support --trailerLi Chen, Oct 22, 2025
  13. Phillip WoodOct 23, 2025
  14. 10/29 rebase: inline trailer state pathsLi Chen, Oct 22, 2025
  15. 11/29 rebase: reuse buffer for trailer argsLi Chen, Oct 22, 2025
  16. 12/29 rebase: drop redundant strbuf_release callLi Chen, Oct 22, 2025
  17. 13/29 rebase: skip stripping of --trailer option prefixLi Chen, Oct 22, 2025
  18. 14/29 rebase: die on invalid trailer argsLi Chen, Oct 22, 2025
  19. 15/29 rebase: validate trailers with configured separatorsLi Chen, Oct 22, 2025
  20. 16/29 sequencer: add trailers to message before writing fileLi Chen, Oct 22, 2025
  21. 17/29 t3440: create expect files at point of useLi Chen, Oct 22, 2025
  22. 18/29 t3440: check apply backend error includes optionLi Chen, Oct 22, 2025
  23. 19/29 t3440: use test_commit_message for trailer checksLi Chen, Oct 22, 2025
  24. 20/29 t3440: drop redundant resets and pass branch to rebase where neededLi Chen, Oct 22, 2025
  25. 21/29 t3440: assert trailer on HEAD after conflict rebaseLi Chen, Oct 22, 2025
  26. 22/29 rebase: persist --trailer options across restartsLi Chen, Oct 22, 2025
  27. 23/29 t3440: remove redundant --keep-emptyLi Chen, Oct 22, 2025
  28. 24/29 t3440: use helper for trailer checksLi Chen, Oct 22, 2025
  29. 25/29 t3440: test --trailer without valuesLi Chen, Oct 22, 2025
  30. 26/29 t3440: convert ex.com to example.comLi Chen, Oct 22, 2025
  31. 27/29 t3440: ensure trailers persist after rebase continueLi Chen, Oct 22, 2025
  32. 28/29 t3440: exercise trailer config mappingLi Chen, Oct 22, 2025
  33. 29/29 sequencer: honor --trailer with fixup -CLi Chen, Oct 22, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.