Re: aw/t9811-modernize, was Re: What's cooking in git.git (Apr 2025, #04; Tue, 15)
- From
Jeff King <peff@peff.net>
- Date
- Apr 18, 2025, 21:57 UTC
- Message-ID
- <20250418215723.GA91116@coredump.intra.peff.net>
- In-Reply-To
- <xmqqmscd9mbl.fsf@gitster.g>
On Fri, Apr 18, 2025 at 02:44:30PM -0700, Junio C Hamano wrote:
Show 11 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > > > Jeff King <peff@peff.net> writes: > > > >> So I don't know if git-p4 got smarter, or what. But we should probably > >> back out at least that part of the commit until we figure out what's > >> going on (where "we" is somebody who cares a lot more about p4 than I > >> do). > > > > Yes, and there was another breakage in that 2-hunk patch in the > > other hunk I sent out a fix for a few minutes ago.
Oh, sorry, I totally missed your fixes. Obviously, yeah, your patches look good. ;)
> We seem to have quite a many ubuntu/linux test jobs, none of which > failed due to the obvious syntax error in t9811, which probalby > means we are not running p4 tests at all on any of our Linux jobs.
I wondered that, too, but then I pulled the instructions for downloading p4 from ci/install-dependencies, under the ubuntu heading. I wonder if that is not triggering for some reason.
-Peff