aw/t9811-modernize, was Re: What's cooking in git.git (Apr 2025, #04; Tue, 15)

From: Jeff King <peff@peff.net>
Date: Apr 18, 2025, 21:35 UTC
Message-ID: <20250418213531.GA89733@coredump.intra.peff.net>
In-Reply-To: <xmqqbjsxkn6x.fsf@gitster.g>

On Tue, Apr 15, 2025 at 04:41:10PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> * aw/t9811-modernize (2025-04-15) 1 commit
>  - t9811: be more precise to check importing of tags
> 
>  Test updates.
> 
>  Will merge to 'next'?
>  source: <20250412061957.81747-2-anthonywang03@icloud.com>

This commit seems to be the cause of consistent failures in t9811 in CI for macos (and I was able to bisect locally on linux after installing p4).

The problem is this bit from the commit message:

  Additionally, we add a negative test to verify that a possible
  uninteded tag does not show up in the imported repository.

This line from the test output shows that command failing:

  test_must_fail: command succeeded: git show-ref --verify refs/tags/TAG_F1_ONLY

And indeed, that tag is definitely there. The original test comment says:

  # - a tag that is only on one file; this kind of tag
  #   cannot be imported (at least not easily).

So I don't know if git-p4 got smarter, or what. But we should probably back out at least that part of the commit until we figure out what's going on (where "we" is somebody who cares a lot more about p4 than I do).

-Peff