git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 8/8] t7004: make use of write_script

From
AbdAlRahman Gad <abdobngad@gmail.com>
Date
Aug 7, 2024, 12:58 UTC
Message-ID
<20240807130259.28381-9-abdobngad@gmail.com>
In-Reply-To
<20240807130259.28381-1-abdobngad@gmail.com>

Use write_script which takes care of emitting the `#!/bin/sh` line and the `chmod +x`.

Signed-off-by: AbdAlRahman Gad <abdobngad@gmail.com>
---
 t/t7004-tag.sh | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index 046a5bd9bc..b1316e62f4 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -974,13 +974,11 @@ test_expect_success GPG 'sign with an unknown id (2)' '
 '
 
 test_expect_success GPG '-u implies signed tag' '
-	cat >fakeeditor <<-\EOF &&
-	#!/bin/sh
+	write_script fakeeditor <<-\EOF &&
 	test -n "$1" && exec >"$1"
 	echo A signed tag message
 	echo from a fake editor.
 	EOF
-	chmod +x fakeeditor &&
 
 	get_tag_header implied-sign $commit commit $time >expect &&
 	./fakeeditor >>expect &&
@@ -1415,11 +1413,9 @@ test_expect_success GPG,RFC1991 'creating a signed tag with rfc1991' '
 '
 
 test_expect_success GPG,RFC1991 'reediting a signed tag body omits signature' '
-	cat >fakeeditor <<-\EOF &&
-	#!/bin/sh
+	write_script fakeeditor <<-\EOF &&
 	cp "$1" actual
 	EOF
-	chmod +x fakeeditor &&
 	echo "rfc1991" >gpghome/gpg.conf &&
 	echo "RFC1991 signed tag" >expect &&
 	GIT_EDITOR=./fakeeditor git tag -f -s rfc1991-signed-tag $commit &&
-- 
2.43.0
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 12 in “[Newcomer] t7004: modernize the style”
  1. 0/8 [Newcomer] t7004: modernize the styleAbdAlRahman Gad, Aug 7, 2024
  2. 1/8 t7004: remove space after redirect operatorsAbdAlRahman Gad, Aug 7, 2024
  3. 2/8 t7004: one command per lineAbdAlRahman Gad, Aug 7, 2024
  4. 4/8 t7004: use indented here-docAbdAlRahman Gad, Aug 7, 2024
  5. 3/8 t7004: do not prepare things outside test_expect_successAbdAlRahman Gad, Aug 7, 2024
  6. 5/8 t7004: description on the same line as test_expect_successAbdAlRahman Gad, Aug 7, 2024
  7. 6/8 t7004: test description and test body seperated with backslashAbdAlRahman Gad, Aug 7, 2024
  8. 7/8 t7004: use single quotes instead of double quotesAbdAlRahman Gad, Aug 7, 2024
  9. Junio C HamanoAug 8, 2024
  10. 8/8 t7004: make use of write_scriptAbdAlRahman Gad, Aug 7, 2024
  11. Junio C HamanoAug 8, 2024
  12. AbdAlRahman GadAug 8, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.