[PATCH v5 0/8] [Newcomer] t7004: modernize the style
- From
AbdAlRahman Gad <abdobngad@gmail.com>
- Date
- Aug 7, 2024, 12:58 UTC
- Message-ID
- <20240807130259.28381-1-abdobngad@gmail.com>
- Remove whitespace after the redirect operators.
- Move number of expect files prepared outside of test_expect_success to be inside the tests that use it.
- Split some lines that have two commands into two lines one command each.
- Turn some "<<\EOF" into "<<-\EOF" and indent their body.
- Avoid using pipes in the output from "test-tool ref-store" and write the output to a file.
- Change test_expect_success that are seperated from its name to be on the same line.
- Avoid separating test Description and test body with backslash
- Use single quotes instead of double quotes for test description and body.
- Use write_script which takes care of emitting the `#!/bin/sh` line and the `chmod +x`.
There are still tests that could lose exit status to pipe. This needs to be modernized too, I will fix them in another patch series.
AbdAlRahman Gad (8): t7004: remove space after redirect operators t7004: one command per line t7004: do not prepare things outside test_expect_success t7004: use indented here-doc t7004: description on the same line as test_expect_success t7004: test Description and test body seperated with backslash t7004: use single quotes instead of double quotes t7004: make use of write_script
t/t7004-tag.sh | 1144 +++++++++++++++++++++++------------------------- 1 file changed, 549 insertions(+), 595 deletions(-)
base-commit: 406f326d271e0bacecdb00425422c5fa3f314930
-- 2.43.0