git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 2/8] t7004: one command per line

From
AbdAlRahman Gad <abdobngad@gmail.com>
Date
Aug 7, 2024, 12:58 UTC
Message-ID
<20240807130259.28381-3-abdobngad@gmail.com>
In-Reply-To
<20240807130259.28381-1-abdobngad@gmail.com>

One of the tests in t7004 has multiple commands on a single line, which is discouraged. Adapt these by splitting up these into one line per command.

Signed-off-by: AbdAlRahman Gad <abdobngad@gmail.com>
---
 t/t7004-tag.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index 3100a4c219..09ce287559 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -213,9 +213,11 @@ mytag
 EOF
 test_expect_success \
 	'trying to delete tags without params should succeed and do nothing' '
-	git tag -l >actual && test_cmp expect actual &&
+	git tag -l >actual &&
+	test_cmp expect actual &&
 	git tag -d &&
-	git tag -l >actual && test_cmp expect actual
+	git tag -l >actual &&
+	test_cmp expect actual
 '
 
 test_expect_success \
-- 
2.43.0
Previous: AbdAlRahman GadNext: AbdAlRahman Gad
Message 3 of 12 in “[Newcomer] t7004: modernize the style”
  1. 0/8 [Newcomer] t7004: modernize the styleAbdAlRahman Gad, Aug 7, 2024
  2. 1/8 t7004: remove space after redirect operatorsAbdAlRahman Gad, Aug 7, 2024
  3. 2/8 t7004: one command per lineAbdAlRahman Gad, Aug 7, 2024
  4. 4/8 t7004: use indented here-docAbdAlRahman Gad, Aug 7, 2024
  5. 3/8 t7004: do not prepare things outside test_expect_successAbdAlRahman Gad, Aug 7, 2024
  6. 5/8 t7004: description on the same line as test_expect_successAbdAlRahman Gad, Aug 7, 2024
  7. 6/8 t7004: test description and test body seperated with backslashAbdAlRahman Gad, Aug 7, 2024
  8. 7/8 t7004: use single quotes instead of double quotesAbdAlRahman Gad, Aug 7, 2024
  9. Junio C HamanoAug 8, 2024
  10. 8/8 t7004: make use of write_scriptAbdAlRahman Gad, Aug 7, 2024
  11. Junio C HamanoAug 8, 2024
  12. AbdAlRahman GadAug 8, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.