git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] test-lib: GIT_TEST_SANITIZE_LEAK_LOG enabled by default

From
Jeff King <peff@peff.net>
Date
Jul 17, 2024, 07:02 UTC
Message-ID
<20240717070203.GH547635@coredump.intra.peff.net>
In-Reply-To
<fe8cd0d1-e451-43d0-b033-11bbb6d1ed56@gmail.com>
On Thu, Jul 11, 2024 at 11:10:51PM +0900, Rubén Justo wrote:
Show 24 quoted lines
> As we currently describe in t/README, it can happen that:
> 
>     Some tests run "git" (or "test-tool" etc.) without properly checking
>     the exit code, or git will invoke itself and fail to ferry the
>     abort() exit code to the original caller.
> 
> Therefore, GIT_TEST_SANITIZE_LEAK_LOG=true is needed to be set to
> capture all memory leaks triggered by our tests.
> 
> It seems unnecessary to force users to remember this option, as
> forgetting it could lead to missed memory leaks.
> 
> We could solve the problem by making it "true" by default, but that
> might suggest we think "false" makes sense, which isn't the case.
> 
> Therefore, the best approach is to remove the option entirely while
> maintaining the capability to detect memory leaks in blind spots of our
> tests.
> 
> Signed-off-by: Rubén Justo <rjusto@gmail.com>
> ---
> 
> This iteration mainly reduces the noise introduced in the previous
> iteration.
Thanks, this one looks good to me.
-Peff
Previous: Rubén Justo
Message 10 of 10 in “test-lib: GIT_TEST_SANITIZE_LEAK_LOG enabled by default”
  1. test-lib: GIT_TEST_SANITIZE_LEAK_LOG enabled by defaultRubén Justo, Jul 10, 2024
  2. Jeff KingJul 10, 2024
  3. Patrick SteinhardtJul 22, 2024
  4. test-lib: GIT_TEST_SANITIZE_LEAK_LOG enabled by defaultRubén Justo, Jul 10, 2024
  5. Junio C HamanoJul 10, 2024
  6. Rubén JustoJul 10, 2024
  7. Jeff KingJul 10, 2024
  8. Rubén JustoJul 11, 2024
  9. test-lib: GIT_TEST_SANITIZE_LEAK_LOG enabled by defaultRubén Justo, Jul 11, 2024
  10. Jeff KingJul 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.