Re: [PATCH] test-lib: GIT_TEST_SANITIZE_LEAK_LOG enabled by default

From: Jeff King <peff@peff.net>
Date: Jul 10, 2024, 01:12 UTC
Message-ID: <20240710011206.GC1526498@coredump.intra.peff.net>
In-Reply-To: <598149bf-6541-4c9e-8c94-a108e3ee7fd7@gmail.com>

On Wed, Jul 10, 2024 at 02:51:58AM +0200, Rubén Justo wrote:

Show 11 quoted lines

> As we describe in t/README, it can happen that:
> 
>     Some tests run "git" (or "test-tool" etc.) without properly checking
>     the exit code, or git will invoke itself and fail to ferry the
>     abort() exit code to the original caller.
> 
> Therefore, GIT_TEST_SANITIZE_LEAK_LOG must be set to true to capture all
> memory leaks triggered by the tests when SANITIZE=leak.
> 
> Set it to true by default, and stop worrying about someone checking for
> leaks who isn't aware of this option and might be missing some leaks.

I'm obviously in favor of this direction, but...why stop here? Do we expect somebody to set it to false? If not, then can't we just get rid of it entirely?

-Peff