Re: [PATCH 0/4] some v2 capability advertisement cleanups

From: Jeff King <peff@peff.net>
Date: Mar 4, 2024, 10:02 UTC
Message-ID: <20240304100202.GC3723539@coredump.intra.peff.net>
In-Reply-To: <ZeV7-NkUwT53IvIa@tanuki>

On Mon, Mar 04, 2024 at 08:44:56AM +0100, Patrick Steinhardt wrote:

Show 13 quoted lines

> On Wed, Feb 28, 2024 at 05:46:25PM -0500, Jeff King wrote:
> > While working on another series, I noticed that upload-pack will accept
> > the "packfile-uris" directive even if we didn't advertise it. That's not
> > a huge deal in practice, but the spec says we're not supposed to. And
> > while cleaning that up, I noticed a bit of duplication in the existing
> > advertisement/allow code.
> > 
> > So patches 1-3 clean up the situation a bit, and then patch 4 tightens
> > up the packfile-uris handling.
> 
> This patch series was really easy to follow and feels like the right
> thing to do. I've got a couple of nits, but none of them are important
> enough to warrant a reroll.

Thanks for reviewing. The typos you found are definitely all wrong, but I think the topic is in 'next' already (and they were all just in the commit messages).

-Peff