git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/4] some v2 capability advertisement cleanups

From
Jeff King <peff@peff.net>
Date
Feb 28, 2024, 22:46 UTC
Message-ID
<20240228224625.GA1158651@coredump.intra.peff.net>

While working on another series, I noticed that upload-pack will accept the "packfile-uris" directive even if we didn't advertise it. That's not a huge deal in practice, but the spec says we're not supposed to. And while cleaning that up, I noticed a bit of duplication in the existing advertisement/allow code.

So patches 1-3 clean up the situation a bit, and then patch 4 tightens up the packfile-uris handling.

There are some small textual conflicts with the series I just posted in:
  https://lore.kernel.org/git/20240228223700.GA1157826@coredump.intra.peff.net/
I'm happy to prepare this on top of that if it's easier.
  [1/4]: upload-pack: use repository struct to get config
  [2/4]: upload-pack: centralize setup of sideband-all config
  [3/4]: upload-pack: use existing config mechanism for advertisement
  [4/4]: upload-pack: only accept packfile-uris if we advertised it
 t/t5702-protocol-v2.sh | 18 +++++++++++++
 upload-pack.c          | 58 +++++++++++++++++++-----------------------
 2 files changed, 44 insertions(+), 32 deletions(-)
-Peff
Next: Jeff King
Message 1 of 15 in “some v2 capability advertisement cleanups”
  1. 0/4 some v2 capability advertisement cleanupsJeff King, Feb 28, 2024
  2. 1/4 upload-pack: use repository struct to get configJeff King, Feb 28, 2024
  3. Patrick SteinhardtMar 4, 2024
  4. 2/4 upload-pack: centralize setup of sideband-all configJeff King, Feb 28, 2024
  5. 3/4 upload-pack: use existing config mechanism for advertisementJeff King, Feb 28, 2024
  6. 4/4 upload-pack: only accept packfile-uris if we advertised itJeff King, Feb 28, 2024
  7. Junio C HamanoFeb 28, 2024
  8. Jeff KingFeb 29, 2024
  9. Junio C HamanoFeb 29, 2024
  10. Jeff KingMar 1, 2024
  11. Patrick SteinhardtMar 4, 2024
  12. Junio C HamanoFeb 28, 2024
  13. Jeff KingFeb 29, 2024
  14. Patrick SteinhardtMar 4, 2024
  15. Jeff KingMar 4, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.