[PATCH 2/4] upload-pack: centralize setup of sideband-all config
- From
Jeff King <peff@peff.net>
- Date
- Feb 28, 2024, 22:47 UTC
- Message-ID
- <20240228224718.GB1158898@coredump.intra.peff.net>
- In-Reply-To
- <20240228224625.GA1158651@coredump.intra.peff.net>
We read uploadpack.allowsidebandall to set a matching flag in our upload_pack_data struct. But for our tests, we also respect GIT_TEST_SIDEBAND_ALL from the environment, and anybody looking at the flag in the struct needs to remember to check both. There's only one such piece of code now, but we're about to add another.
So let's have the config step actually fold the environment value into the struct, letting the rest of the code use the flag in the obvious way.
Signed-off-by: Jeff King <peff@peff.net> --- upload-pack.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/upload-pack.c b/upload-pack.c index e156c1e472..6bda20754d 100644 --- a/upload-pack.c +++ b/upload-pack.c @@ -1390,6 +1390,8 @@ static void get_upload_pack_config(struct repository *r, { repo_config(r, upload_pack_config, data); git_protected_config(upload_pack_protected_config, data); + + data->allow_sideband_all |= git_env_bool("GIT_TEST_SIDEBAND_ALL", 0); } void upload_pack(const int advertise_refs, const int stateless_rpc, @@ -1639,8 +1641,7 @@ static void process_args(struct packet_reader *request, continue; } - if ((git_env_bool("GIT_TEST_SIDEBAND_ALL", 0) || - data->allow_sideband_all) && + if (data->allow_sideband_all && !strcmp(arg, "sideband-all")) { data->writer.use_sideband = 1; continue;
-- 2.44.0.rc2.424.gbdbf4d014b