Re: [PATCH v2 1/1] push: make '-u' have default argument

From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Date: Dec 8, 2021, 06:12 UTC
Message-ID: <20211208061221.133-1-chakrabortyabhradeep79@gmail.com>
In-Reply-To: <CAPig+cRxU=pT-qCp-xpHcoae45oxz1d-eRh+QF-SJFM3B-6KyQ@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 8 quoted lines

> As above, because calls to this function are part of the &&-chain in
> test bodies, it is important for the &&-chain to be intact in the
> function too. It's especially important in this case since this
> function is actually checking for specific conditions. As it's
> currently written -- with a broken &&-chain -- if the first
> test_expect_code() fails, we'll never know about it since that exit
> code gets lost; only the exit code from the second test_expect_code()
> has any bearing on the overall result of the test.

Thanks so much for all the suggestions! I am little beginner in shell scripting. It would help me a lot!

> s/messagesdo/messages do/

oops :|

> The captured stdout in `out` doesn't seem to be used, so it's probably
> better to drop that redirection.

okay.