Re: [RFC PATCH 1/1] push: make '-u' have default arguments

From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Date: Dec 3, 2021, 19:27 UTC
Message-ID: <20211203192716.18444-1-chakrabortyabhradeep79@gmail.com>
In-Reply-To: <xmqqtufpsikp.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> wrote:

> That of course is not an improvement but actively hurts them.  We
> shouldn't be making it easier for our users to hurt themselves.

Hmm. In the scenario you mentioned, the proposed change is clearly breaking. Thanks for notifying.

Show 7 quoted lines

> Shouldn't the rule be something like "if 'git push $args' (where
> $args may be nothing, or any options other than '-u') pushes a
> branch (or a set of branches) to a repository, 'git push -u $args'
> (with the same $args) should set the branch.*.{remote,merge} for the
> branch(es) to the same repository" for the introduction of default
> to be truly an improvement?  Or is it too strict and makes the rule
> not to trigger even for the intended audience?

Sounds good to me. But what if 'push.default' set to 'nothing'? Do the proposed default arguments (I am saying about only the default arguments; not the changes in code) are right fit for that case?