Re: [PATCH 16/16] refs: drop "broken" flag from for_each_fullref_in()

From: Jonathan Tan <jonathantanmy@google.com>
Date: Sep 27, 2021, 17:47 UTC
Message-ID: <20210927174703.530229-1-jonathantanmy@google.com>
In-Reply-To: <YU4dkMt6rWhmsOlq@coredump.intra.peff.net>

Show 13 quoted lines

> No callers pass in anything but "0" here. Likewise to our sibling
> functions. Note that some of them ferry along the flag, but none of
> their callers pass anything but "0" either.
> 
> Nor is anybody likely to change that. Callers which really want to see
> all of the raw refs use for_each_rawref(). And anybody interested in
> iterating a subset of the refs will likely be happy to use the
> now-default behavior of showing broken refs, but omitting dangling
> symlinks.
> 
> So we can get rid of this whole feature.
> 
> Signed-off-by: Jeff King <peff@peff.net>

All the patches look good.
Reviewed-by: Jonathan Tan <jonathantanmy@google.com>

As you have mentioned before, this clashes with my series [1]. But since I'll need to update my series anyway to reinclude the DO_FOR_EACH_INCLUDE_BROKEN flag, the obvious thing is for me to rebase mine on top of yours so that yours can go in first, so I don't mind doing that.

[1] https://lore.kernel.org/git/cover.1632242495.git.jonathantanmy@google.com/