Re: [PATCH 12/16] refs: turn on GIT_REF_PARANOIA by default

From: Jonathan Tan <jonathantanmy@google.com>
Date: Sep 27, 2021, 17:42 UTC
Message-ID: <20210927174237.529476-1-jonathantanmy@google.com>
In-Reply-To: <YU4c9S6jypbS4YCK@coredump.intra.peff.net>

> Deleting a
> broken ref now actually tells the hooks the correct "before" state,
> rather than a confusing null oid.

I believe that this is due to write_head_info() in builtin/receive-pack.c now advertising the broken ref, so that the client knows what the old OID is when pushing in order to delete the ref (verified by running the relevant "git push" in the test with GIT_TRACE_PACKET=1, with and without GIT_REF_PARANOIA=0). If rerolling, maybe this is worth adding in parentheses (e.g. "(because such a ref would be advertised to the client and the client would thus send the "before" OID when deleting it)").

All the patches up to this look good.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.