Re: [PATCH 01/16] t7900: clean up some more broken refs

From: Jonathan Tan <jonathantanmy@google.com>
Date: Sep 27, 2021, 17:38 UTC
Message-ID: <20210927173818.528679-1-jonathantanmy@google.com>
In-Reply-To: <YU4Zse+dAeDg8RqV@coredump.intra.peff.net>

Show 16 quoted lines

> @@ -277,7 +277,7 @@ test_expect_success 'incremental-repack task' '
>  
>  	# Delete refs that have not been repacked in these packs.
>  	git for-each-ref --format="delete %(refname)" \
> -		refs/prefetch refs/tags >refs &&
> +		refs/prefetch refs/tags refs/remotes >refs &&
>  	git update-ref --stdin <refs &&
>  
>  	# Replace the object directory with this pack layout.
> @@ -286,6 +286,10 @@ test_expect_success 'incremental-repack task' '
>  	ls $packDir/*.pack >packs-before &&
>  	test_line_count = 3 packs-before &&
>  
> +	# make sure we do not have any broken refs that were
> +	# missed in the deletion above
> +	git for-each-ref &&

For what it's worth, I verified that a fatal error is indeed caused in "git for-each-ref" if refs/remotes was not deleted. This patch looks good.