Re: [PATCH v5 03/14] packfile-uri: support for excluding commit objects

From: Teng Long <dyroneteng@gmail.com>
Date: Sep 2, 2021, 12:51 UTC
Message-ID: <20210902125102.78016-1-dyroneteng@gmail.com>
In-Reply-To: <xmqqfsuwc4cl.fsf@gitster.g>

Junio C Hamano wrote:

> Whenever you say "which means", e.g. "We do X, which means we do Y",
> think twice to see if you do not even have to say X.  In this
> particular sentence, I think you can simplify the description
> greatly and you do not even have to use the word "recursive".

Forgive my English for another accident.

Will be fixed in the next patch.

Show 13 quoted lines

> Also, because this "exclusion by a commit" does not work like the
> usual "reachability" relationship Git users are familiar with, it
> would help to highlight what is special that is done here to the
> readers.
> 
> Taking the above together, along the lines of ...
> 
>     When a commit is specified to be excluded as packfile-uri,
>     exclude all trees and blobs contained in its top-level tree, as
>     well as the commit itself, but not the ancestors of the commit
>     and objects that are reachable by them.
> 
> or something like that, perhaps.

Agree.

I will use your suggestion in the next patch (may be slightly modified).

In the next patch, I originally planned to introduce the exclusion of the commit and with all it's ancestor objects. The problems in the current patch will also be fixed in the next patch.

Thanks.