Re: [PATCH v5 06/14] t5702: replace with "test_when_finished" for cleanup

From: Teng Long <dyroneteng@gmail.com>
Date: Sep 2, 2021, 11:37 UTC
Message-ID: <20210902113740.76680-1-dyroneteng@gmail.com>
In-Reply-To: <87zgt5axjv.fsf@evledraar.gmail.com>

> Thanks, much needed cleanup. I have an unsubmitted patch to do pretty
> much this, plus some: https://github.com/avar/git/commit/27b3543c6ed
>
> You might find the difference between the two interesting..

Cool.

I had took a look at the commit. In comparision, I ignored some places that need to cleanup, I don't know if I got your meaning?

If so, how to deal with this situation better, continue my work or rebase your commit to the current patchset?

Show 5 quoted lines

>> -test_done
>> +test_done
>> \ No newline at end of file
>
> More newline churn.

Will be fixed in the next patch.

Thank you.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.