Re: [PATCH v5 09/14] commit.h: add wrapped tags in commit struct

From: Teng Long <dyroneteng@gmail.com>
Date: Sep 2, 2021, 12:17 UTC
Message-ID: <20210902121709.77198-1-dyroneteng@gmail.com>
In-Reply-To: <87wno9axfs.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> Can't we store this info on the side between these two static functions
> somehow, instead of adding this "wraps" to all commit structs?
>

Thanks very much and I have some doubts.

> ... instead of adding this "wraps" to all commit structs?

I think "adding this "wraps" to all commit struct" is an easy but a little rough indeed. I didn't know if this is okay at the time. So I pushed the patch, hoping to ask some different opinions.

> Can't we store this info on the side between these two static functions...

Do you mean to use static storage to share the "wraps", or other way? I want to make sure that I understand your opinion accurately.

Thank you.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.