Re: [PATCH v2 4/4] submodule: cache superproject gitdir during 'update'

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jul 27, 2021, 17:51 UTC
Message-ID: <20210727175151.2462983-1-jonathantanmy@google.com>
In-Reply-To: <20210616004508.87186-5-emilyshaffer@google.com>

> A cached path to the superproject's gitdir might be added during 'git

[snip]

> +		# Cache a pointer to the superproject's gitdir. This may have

Patches 3 and 4 look good to me except that for me, a cache is something that lets us avoid an expensive computation. But as far as I know, we're not planning to perform the expensive computation in the absence of a cache. Maybe the word "record" would fit better.

This is nit-picky, though, and if others think that the word "cache" fits here, that's fine by me too.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.