Re: [PATCH v3 0/4] cache parent project's gitdir in submodules

From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date: Sep 4, 2021, 17:50 UTC
Message-ID: <CAHd-oW6Ko2s7uXZDbEBHpVhjNiXNcR74DriA-V=9cfOcN6bjFw@mail.gmail.com>
In-Reply-To: <20210819200953.2105230-1-emilyshaffer@google.com>

Hi, Emily

On Thu, Aug 19, 2021 at 5:10 PM Emily Shaffer <emilyshaffer@google.com> wrote:

Show 6 quoted lines

>
> Emily Shaffer (4):
>   t7400-submodule-basic: modernize inspect() helper
>   introduce submodule.superprojectGitDir record
>   submodule: record superproject gitdir during absorbgitdirs
>   submodule: record superproject gitdir during 'update'

I left a few comments on patches 2 and 3. They are mostly about things we have already discussed on the Review Club, but I got the chance to experiment with the code a bit more after that, and I thought it could be helpful to provide these inline suggestions. Hope it helps, and thanks for the series!

Thanks, Matheus

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.