From: Jonathan Tan <jonathantanmy@google.com>
Date: Tue, 27 Jul 2021 17:51:51 GMT
Subject: Re: [PATCH v2 4/4] submodule: cache superproject gitdir during 'update'
Message-ID: <20210727175151.2462983-1-jonathantanmy@google.com>
In-Reply-To: <20210616004508.87186-5-emilyshaffer@google.com>

> A cached path to the superproject's gitdir might be added during 'git

[snip]

> +		# Cache a pointer to the superproject's gitdir. This may have

Patches 3 and 4 look good to me except that for me, a cache is something
that lets us avoid an expensive computation. But as far as I know, we're
not planning to perform the expensive computation in the absence of a
cache. Maybe the word "record" would fit better.

This is nit-picky, though, and if others think that the word "cache"
fits here, that's fine by me too.