Re: [PATCH 5/7] t0060: test obscured .gitattributes and .gitignore matching

From: Jeff King <peff@peff.net>
Date: Oct 6, 2020, 14:01 UTC
Message-ID: <20201006140158.GA6601@coredump.intra.peff.net>
In-Reply-To: <nycvar.QRO.7.76.6.2010052306470.50@tvgsbejvaqbjf.bet>

On Mon, Oct 05, 2020 at 11:20:48PM +0200, Johannes Schindelin wrote:

Show 13 quoted lines

> > > > Note that the ntfs magic prefix names in the tests come from the
> > > > algorithm described in e7cb0b4455 (and are different for each file).
> > >
> > > Doesn't block this patch, but I'm curious: how hard would it be to make
> > > a test with an NTFS prerequisite that makes sure we got the magic prefix
> > > right?
> >
> > I suspect hard since Dscho punted on it in the original series. :) If I
> > understand correctly, it would require having an NTFS filesystem, and
> > generating 10,000+ files with a clashing prefix.
> 
> It's not quite _as_ bad: you only need to generate 4 files with a clashing
> prefix and then the real one:

Ah, that really isn't that bad, then. Still, I don't mind leaving this as-is under the notion that if the algorithm does change, it would likely make it onto your radar anyway (or the radar of _anybody_ who would raise the issue).

-Peff