Re: [PATCH 3/7] t7415: rename to expand scope

From: Jeff King <peff@peff.net>
Date: Oct 5, 2020, 08:49 UTC
Message-ID: <20201005084946.GE2862927@coredump.intra.peff.net>
In-Reply-To: <20201005083441.GL1166820@google.com>

On Mon, Oct 05, 2020 at 01:34:41AM -0700, Jonathan Nieder wrote:

Show 5 quoted lines

> > I couldn't think of a better name for "files that start with .git". I
> > almost called it "dot-git", but then I worried about confusion with the
> > actual ".git" directory.
> 
> t7450-dot-gitfoo-files.sh seems clear to me.

Heh, that was actually one of the ones I thought of, but I worried that "foo" was too confusing (likewise, I almost called the test-tool function check_dotgitfoo(const char *foo)). I guess dotgitx would follow the same pattern here.

Show 13 quoted lines

> > In practice, I doubt it matters that much. We don't tend to run the test
> > suite serially in order these days anyway, so the notion that finding a
> > bug in an early test might save you CPU time or time spent reading error
> > messages likely no longer applies.
> 
> I see --- the point here is that because it's using e.g. "git clone
> --recurse-submodules", we want it to be later than the other clone
> tests?
> 
> I think I'd like us to move away from having the numbers at all some
> day (since collisions are very common), but there's probably not much
> to discuss there until one of us comes up with a proposal that still
> makes it easy to do things like "skip all git-svn tests". :)

I'd be happy to get away from numbers, too. They're a frequent pain when dealing with duplicates, or when we run out of space in a group (I have another series to split t9001 into a few separate scripts, but I have to move either it or the unrelated bits at t9002).

An obvious solution is providing some kind of name hierarchy. E.g.:

  t-svn-commit-diff.sh
  t-svn-dcommit-auto-props.sh
  t-svn-dcommit-clobber-series.sh
  t-svn-dcommit-concurrent.sh
  t-svn-dcommit-crlf.sh
  t-svn-dcommit-funky-renames.sh
  t-svn-dcommit-interactive.sh
  t-svn-dcommit-merge.sh
  t-svn-dcommit-new-file.sh
  t-svn-deep-rmdir.sh

Then you could skip t-svn-*, or just t-svn-dcommit-*, or even t-svn-commit-diff.12.

The "t-" is ugly, but lets you distinguish test scripts from other shell scripts in the directory.

We could also use actual directories for the hierarchy. svn/dcommit/*, etc. The t/ directory is rather big. It does make it a little more work to assemble the full set of tests (you have to use `find` rather than a glob).

-Peff