git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] log_tree_diff: get rid of extra check for NULL

From
Sergey Organov <sorganov@gmail.com>
Date
Aug 28, 2020, 11:05 UTC
Message-ID
<20200828110526.21145-3-sorganov@gmail.com>
In-Reply-To
<20200828110526.21145-1-sorganov@gmail.com>

Get rid of needless check of 'parents' for NULL. The NULL case is already handled right above, and 'parents' is dereferenced without check below anyway.

Signed-off-by: Sergey Organov <sorganov@gmail.com>
---
 log-tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/log-tree.c b/log-tree.c
index c01932fa72bf..8ac285a25af5 100644
--- a/log-tree.c
+++ b/log-tree.c
@@ -917,7 +917,7 @@ static int log_tree_diff(struct rev_info *opt, struct commit *commit, struct log
 	}
 
 	/* More than one parent? */
-	if (parents && parents->next) {
+	if (parents->next) {
 		if (opt->ignore_merges)
 			return 0;
 		else if (opt->combine_merges)
-- 
2.25.1
Previous: Sergey OrganovNext: Sergey Organov
Message 2 of 5 in “log_tree_diff: simplify”
  1. 0/2 log_tree_diff: simplifySergey Organov, Aug 28, 2020
  2. 2/2 log_tree_diff: get rid of extra check for NULLSergey Organov, Aug 28, 2020
  3. 1/2 log_tree_diff: get rid of code duplication for first_parent_onlySergey Organov, Aug 28, 2020
  4. Sergey OrganovSep 4, 2020
  5. Junio C HamanoSep 6, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.