git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 5/5] t7401: add a NEEDSWORK

From
Shourya Shukla <shouryashukla.oo@gmail.com>
Date
Aug 21, 2020, 16:59 UTC
Message-ID
<20200821165952.14376-6-shouryashukla.oo@gmail.com>
In-Reply-To
<20200821165952.14376-1-shouryashukla.oo@gmail.com>

Add a NEEDSWORK regarding the outdated syntax and working of the test, which may need to be improved to obtain better and desired results.

While at it, change the word 'test' to 'test script' in the test description to avoid ambiguity.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Helped-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>
---
 t/t7401-submodule-summary.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh
index 1491ab6448..cc87d26619 100755
--- a/t/t7401-submodule-summary.sh
+++ b/t/t7401-submodule-summary.sh
@@ -5,8 +5,11 @@
 
 test_description='Summary support for submodules
 
-This test tries to verify the sanity of summary subcommand of git submodule.
+This test script tries to verify the sanity of summary subcommand of git submodule.
 '
+# NEEDSWORK: This test script is old fashioned and may need a big cleanup due to
+# various reasons, one of them being that there are lots of commands taking place
+# outside of 'test_expect_success' block, which is no longer in good-style.
 
 . ./test-lib.sh
 
-- 
2.28.0
Previous: Shourya ShuklaNext: Shourya Shukla
Message 4 of 6 in “t7401: modernize, cleanup and more”
  1. Shourya ShuklaAug 21, 2020
  2. 1/5 t7401: modernize styleShourya Shukla, Aug 21, 2020
  3. 3/5 t7401: change syntax of test_i18ncmp calls for clarityShourya Shukla, Aug 21, 2020
  4. 5/5 t7401: add a NEEDSWORKShourya Shukla, Aug 21, 2020
  5. 4/5 t7401: change indentation for enhanced readabilityShourya Shukla, Aug 21, 2020
  6. 2/5 t7401: use 'short' instead of 'verify' and cut in rev-parse callsShourya Shukla, Aug 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.