git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 3/5] t7401: change syntax of test_i18ncmp calls for clarity

From
Shourya Shukla <shouryashukla.oo@gmail.com>
Date
Aug 21, 2020, 16:59 UTC
Message-ID
<20200821165952.14376-4-shouryashukla.oo@gmail.com>
In-Reply-To
<20200821165952.14376-1-shouryashukla.oo@gmail.com>

Change the test_i18ncmp syntax from 'test_i18ncmp actual expected' to 'test_i18ncmp expected actual' to align it with the convention followed by other tests in the test script.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>
---
 t/t7401-submodule-summary.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh
index ccbac875fe..3f580455f7 100755
--- a/t/t7401-submodule-summary.sh
+++ b/t/t7401-submodule-summary.sh
@@ -181,7 +181,7 @@ test_expect_success 'typechanged submodule(submodule->blob), --cached' "
   < Add foo5
 
 EOF
-	test_i18ncmp actual expected
+	test_i18ncmp expected actual
 "
 
 test_expect_success 'typechanged submodule(submodule->blob), --files' "
@@ -191,7 +191,7 @@ test_expect_success 'typechanged submodule(submodule->blob), --files' "
   > Add foo5
 
 EOF
-	test_i18ncmp actual expected
+	test_i18ncmp expected actual
 "
 
 rm -rf sm1 &&
@@ -202,7 +202,7 @@ test_expect_success 'typechanged submodule(submodule->blob)' "
 * sm1 $head4(submodule)->$head5(blob):
 
 EOF
-	test_i18ncmp actual expected
+	test_i18ncmp expected actual
 "
 
 rm -f sm1 &&
@@ -215,7 +215,7 @@ test_expect_success 'nonexistent commit' "
   Warn: sm1 doesn't contain commit $head4_full
 
 EOF
-	test_i18ncmp actual expected
+	test_i18ncmp expected actual
 "
 
 commit_file
@@ -283,7 +283,7 @@ EOF
 
 test_expect_success '--for-status' "
 	git submodule summary --for-status HEAD^ >actual &&
-	test_i18ncmp actual - <<EOF
+	test_i18ncmp - actual <<EOF
 * sm1 $head6...0000000:
 
 * sm2 0000000...$head7 (2):
-- 
2.28.0
Previous: Shourya ShuklaNext: Shourya Shukla
Message 3 of 6 in “t7401: modernize, cleanup and more”
  1. Shourya ShuklaAug 21, 2020
  2. 1/5 t7401: modernize styleShourya Shukla, Aug 21, 2020
  3. 3/5 t7401: change syntax of test_i18ncmp calls for clarityShourya Shukla, Aug 21, 2020
  4. 5/5 t7401: add a NEEDSWORKShourya Shukla, Aug 21, 2020
  5. 4/5 t7401: change indentation for enhanced readabilityShourya Shukla, Aug 21, 2020
  6. 2/5 t7401: use 'short' instead of 'verify' and cut in rev-parse callsShourya Shukla, Aug 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.