git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/5] t7401: modernize style

From
Shourya Shukla <shouryashukla.oo@gmail.com>
Date
Aug 21, 2020, 16:59 UTC
Message-ID
<20200821165952.14376-2-shouryashukla.oo@gmail.com>
In-Reply-To
<20200821165952.14376-1-shouryashukla.oo@gmail.com>

The tests in 't7401-submodule-summary.sh' were written a long time ago and has a violation with respect to our CodingGuidelines which is, incorrect spacing in usages of the redirection operator.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Helped-by: Denton Liu <liu.denton@gmail.com>
Helped-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>
---
 t/t7401-submodule-summary.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh
index 9bc841d085..07d4ba0b26 100755
--- a/t/t7401-submodule-summary.sh
+++ b/t/t7401-submodule-summary.sh
@@ -16,7 +16,7 @@ add_file () {
 	owd=$(pwd)
 	cd "$sm"
 	for name; do
-		echo "$name" > "$name" &&
+		echo "$name" >"$name" &&
 		git add "$name" &&
 		test_tick &&
 		git commit -m "Add $name"
-- 
2.28.0
Previous: Shourya ShuklaNext: Shourya Shukla
Message 2 of 6 in “t7401: modernize, cleanup and more”
  1. Shourya ShuklaAug 21, 2020
  2. 1/5 t7401: modernize styleShourya Shukla, Aug 21, 2020
  3. 3/5 t7401: change syntax of test_i18ncmp calls for clarityShourya Shukla, Aug 21, 2020
  4. 5/5 t7401: add a NEEDSWORKShourya Shukla, Aug 21, 2020
  5. 4/5 t7401: change indentation for enhanced readabilityShourya Shukla, Aug 21, 2020
  6. 2/5 t7401: use 'short' instead of 'verify' and cut in rev-parse callsShourya Shukla, Aug 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.