Re: [PATCH v5 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return

> On 25/07/20 11:01PM, Shourya Shukla wrote:
> > > Following 'enum bisect_error' vocabulary, return variable 'res' is
> > > always non-positive.
> > > Let's use '-res' instead of 'abs(res)' to make the code clearer.
> > 
> > > Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> > > Signed-off-by: Miriam Rubio <mirucam@gmail.com>
> > > Helped-by: Junio C Hamano <gitster@pobox.com>
> > 
> > Although there is no set rule for this, but I think that your sign-off
> > goes at the last generally. This is what I have seen on various patches.
> 
> The rule of thumb I follow is to have these in chronological order. So 
> Christian first mentored, then the patch was published so Junio helped 
> next and finally you sign off the patch before sending it out so that 
> comes last.