git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 00/13] Finish converting git bisect to C part 2

From
Miriam Rubio <mirucam@gmail.com>
Date
Jul 17, 2020, 10:53 UTC
Message-ID
<20200717105406.82226-1-mirucam@gmail.com>

These patches correspond to a second part of patch series of Outreachy project "Finish converting `git bisect` from shell to C" started by Pranit Bauva and Tanushree Tumane (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and continued by me.

These patch series emails were generated from: https://gitlab.com/mirucam/git/commits/git-bisect-work-part2-v5.

I would like to thank Chris Torek and Junio Hamano for reviewing and Christian Couder for his help.

Specific changes ----------------

[3/12] bisect--helper: introduce new `write_in_file()` function
* Fix typo in commit message.
* Change BUG() message.
* Control 'mode' parameter in write mode only.
* Return vprintf error when result is < 0;
* Simplify return in write_terms().
--

[6/12] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in C

*  Add 'mode' parameter control in append mode.
--

[10/12] bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in C

* Remove mark_for_removal() function.
--
Miriam Rubio (4):
  bisect--helper: BUG() in cmd_*() on invalid subcommand
  bisect--helper: use '-res' in 'cmd_bisect__helper' return
  bisect--helper: introduce new `write_in_file()` function
  bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()'
Pranit Bauva (9):
  bisect--helper: reimplement `bisect_autostart` shell function in C
  bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell
    functions in C
  bisect--helper: finish porting `bisect_start()` to C
  bisect--helper: retire `--bisect-clean-state` subcommand
  bisect--helper: retire `--next-all` subcommand
  bisect--helper: reimplement `bisect_state` & `bisect_head` shell
    functions in C
  bisect--helper: retire `--check-expected-revs` subcommand
  bisect--helper: retire `--write-terms` subcommand
  bisect--helper: retire `--bisect-autostart` subcommand
 bisect.c                 |   8 +
 builtin/bisect--helper.c | 443 ++++++++++++++++++++++++++++++++-------
 git-bisect.sh            | 145 +------------
 3 files changed, 378 insertions(+), 218 deletions(-)
-- 
2.25.0
Next: Miriam Rubio
Message 1 of 24 in “Finish converting git bisect to C part 2”
  1. 00/13 Finish converting git bisect to C part 2Miriam Rubio, Jul 17, 2020
  2. 01/13 bisect--helper: BUG() in cmd_*() on invalid subcommandMiriam Rubio, Jul 17, 2020
  3. Shourya ShuklaJul 25, 2020
  4. 03/13 bisect--helper: introduce new `write_in_file()` functionMiriam Rubio, Jul 17, 2020
  5. Junio C HamanoJul 17, 2020
  6. 05/13 bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()'Miriam Rubio, Jul 17, 2020
  7. 04/13 bisect--helper: reimplement `bisect_autostart` shell function in CMiriam Rubio, Jul 17, 2020
  8. Đoàn Trần Công DanhJul 26, 2020
  9. 08/13 bisect--helper: retire `--bisect-clean-state` subcommandMiriam Rubio, Jul 17, 2020
  10. 07/13 bisect--helper: finish porting `bisect_start()` to CMiriam Rubio, Jul 17, 2020
  11. 06/13 bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in CMiriam Rubio, Jul 17, 2020
  12. Junio C HamanoJul 17, 2020
  13. Junio C HamanoJul 25, 2020
  14. 09/13 bisect--helper: retire `--next-all` subcommandMiriam Rubio, Jul 17, 2020
  15. 02/13 bisect--helper: use '-res' in 'cmd_bisect__helper' returnMiriam Rubio, Jul 17, 2020
  16. Shourya ShuklaJul 25, 2020
  17. Junio C HamanoJul 25, 2020
  18. Pratyush YadavJul 27, 2020
  19. Pratyush YadavJul 27, 2020
  20. Junio C HamanoJul 27, 2020
  21. 10/13 bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in CMiriam Rubio, Jul 17, 2020
  22. 11/13 bisect--helper: retire `--check-expected-revs` subcommandMiriam Rubio, Jul 17, 2020
  23. 13/13 bisect--helper: retire `--bisect-autostart` subcommandMiriam Rubio, Jul 17, 2020
  24. 12/13 bisect--helper: retire `--write-terms` subcommandMiriam Rubio, Jul 17, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.