From: Pratyush Yadav <me@yadavpratyush.com>
Date: Mon, 27 Jul 2020 06:46:05 GMT
Subject: Re: [PATCH v5 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return
Message-ID: <20200727064605.xhgtuxh46kukpisv@yadavpratyush.com>
In-Reply-To: <20200727054215.4nfke6byi6m63txf@yadavpratyush.com>

On 27/07/20 11:12AM, Pratyush Yadav wrote:
> On 25/07/20 11:01PM, Shourya Shukla wrote:
> > > Following 'enum bisect_error' vocabulary, return variable 'res' is
> > > always non-positive.
> > > Let's use '-res' instead of 'abs(res)' to make the code clearer.
> > 
> > > Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> > > Signed-off-by: Miriam Rubio <mirucam@gmail.com>
> > > Helped-by: Junio C Hamano <gitster@pobox.com>
> > 
> > Although there is no set rule for this, but I think that your sign-off
> > goes at the last generally. This is what I have seen on various patches.
> 
> The rule of thumb I follow is to have these in chronological order. So 
> Christian first mentored, then the patch was published so Junio helped 
> next and finally you sign off the patch before sending it out so that 
> comes last.

My MUA didn't download Junio's reply earlier for some reason. Sorry for 
the redundant message.

-- 
Regards,
Pratyush Yadav