git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] t7401: modernize style

From
Shourya Shukla <shouryashukla.oo@gmail.com>
Date
Jul 26, 2020, 14:25 UTC
Message-ID
<20200726142553.42545-2-shouryashukla.oo@gmail.com>
In-Reply-To
<20200726142553.42545-1-shouryashukla.oo@gmail.com>

The tests in 't7401-submodule-summary.sh' were written a long time ago and have some violations with respect to our CodingGuidelines such as incorrect spacing in usages of the redirection operator and absence of line feed between statements in case of the '|' (pipe) operator. Update it to match the CodingGuidelines.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>
---
 t/t7401-submodule-summary.sh | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh
index 9bc841d085..4439fb7c17 100755
--- a/t/t7401-submodule-summary.sh
+++ b/t/t7401-submodule-summary.sh
@@ -16,12 +16,13 @@ add_file () {
 	owd=$(pwd)
 	cd "$sm"
 	for name; do
-		echo "$name" > "$name" &&
+		echo "$name" >"$name" &&
 		git add "$name" &&
 		test_tick &&
 		git commit -m "Add $name"
 	done >/dev/null
-	git rev-parse --verify HEAD | cut -c1-7
+	git rev-parse --verify HEAD |
+	cut -c1-7
 	cd "$owd"
 }
 commit_file () {
@@ -125,7 +126,8 @@ commit_file sm1 &&
 head3=$(
 	cd sm1 &&
 	git reset --hard HEAD~2 >/dev/null &&
-	git rev-parse --verify HEAD | cut -c1-7
+	git rev-parse --verify HEAD |
+	cut -c1-7
 )
 
 test_expect_success 'modified submodule(backward)' "
-- 
2.27.0
Previous: Shourya ShuklaNext: Shourya Shukla
Message 2 of 5 in “t7401: modernize, cleanup and warn”
  1. Shourya ShuklaJul 26, 2020
  2. 1/4 t7401: modernize styleShourya Shukla, Jul 26, 2020
  3. 2/4 t7401: change test_i18ncmp syntax for clarityShourya Shukla, Jul 26, 2020
  4. 3/4 t7401: ensure uniformity in the '--for-status' testShourya Shukla, Jul 26, 2020
  5. 4/4 t7401: add a WARNING and a NEEDSWORKShourya Shukla, Jul 26, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.