Re: [PATCH v7] diff: add config option relative

From: Laurent Arnoud <laurent@spkdev.net>
Date: May 22, 2020, 10:48 UTC
Message-ID: <20200522104833.GB2050@spk-laptop>
In-Reply-To: <20200519230124.GA12509@danh.dev>

On Wed, May 20, 2020 at 06:01:24AM +0700, Đoàn Trần Công Danh wrote:

Show 8 quoted lines

> Sorry, I didn't think about this earlier.
> 
> > +	test_expect_success "config diff.relative $relative_opt -p $*" "
> > +		short_blob_file1=$(git rev-parse --short $blob_file1) &&
> > +		short_blob_file2=$(git rev-parse --short $blob_file2) &&
> 
> This test also needs to quote that dollar.
> Beside that, LGTM.

No worries I've submitted a v8 patch, thanks everyone for the reviews

-- 
Laurent

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.