Re: [PATCH v6] diff: add config option relative
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
Show 29 quoted lines
> On 2020-05-18 19:21:03+0200, Laurent Arnoud <laurent@spkdev.net> wrote:
>> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
>> index bb31f0c42b..167b451b89 100644
>> --- a/Documentation/diff-options.txt
>> +++ b/Documentation/diff-options.txt
>> @@ -651,6 +651,8 @@ ifndef::git-format-patch[]
>> not in a subdirectory (e.g. in a bare repository), you
>> can name which subdirectory to make the output relative
>> to by giving a <path> as an argument.
>> + `--no-relative` can be used to countermand both `diff.relative` config
>> + option and previous `--relative`.
>
> Nitpick:
> Please mentions --no-relative in option list:
>
> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
> index 167b451b89..8761c04bc2 100644
> --- a/Documentation/diff-options.txt
> +++ b/Documentation/diff-options.txt
> @@ -645,6 +645,7 @@ ifndef::git-format-patch[]
> on-disk file to tree contents.
>
> --relative[=<path>]::
> +--no-relative::
> When run from a subdirectory of the project, it can be
> told to exclude changes outside the directory and show
> pathnames relative to it with this option. When you are
>
> Together with Eric suggesstion, this patch looks good to me.
Yeah, good suggestions all.
Thanks.