From: Laurent Arnoud <laurent@spkdev.net>
Date: Fri, 22 May 2020 10:48:33 GMT
Subject: Re: [PATCH v7] diff: add config option relative
Message-ID: <20200522104833.GB2050@spk-laptop>
In-Reply-To: <20200519230124.GA12509@danh.dev>

On Wed, May 20, 2020 at 06:01:24AM +0700, Đoàn Trần Công Danh wrote:
> Sorry, I didn't think about this earlier.
> 
> > +	test_expect_success "config diff.relative $relative_opt -p $*" "
> > +		short_blob_file1=$(git rev-parse --short $blob_file1) &&
> > +		short_blob_file2=$(git rev-parse --short $blob_file2) &&
> 
> This test also needs to quote that dollar.
> Beside that, LGTM.

No worries I've submitted a v8 patch, thanks everyone for the reviews

-- 
Laurent