git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] push: unset PARSE_OPT_OPTARG for --recurse-submodules

From
Denton Liu <liu.denton@gmail.com>
Date
Apr 28, 2020, 22:59 UTC
Message-ID
<20200428225908.GA2570028@generichostname>
In-Reply-To
<xmqqwo5z33cz.fsf@gitster.c.googlers.com>
Hi Junio,
On Tue, Apr 28, 2020 at 10:51:56AM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> Here is what I am going to queue for this fix; hopefully it can be
> cherry-picked by folks who maintain older versions of Git for
> distros and in-house use.
> 
> The other "huge" patch has also been adjusted by dropping the first
> hunk on builtin/push.c from it, and then resurrecting the part to
> use OPT_CALLBACK_F() for compare-and-swap (which happened to be in
> the same hunk).

Thanks, that approach makes sense to me. I looked at both patches that you have queued and they look good.

-Denton
Previous: Junio C Hamano
Message 9 of 9 in “Bug v2.23.0: command help for 'git push --recurse-submodules' is incorrect”
  1. Andrew WhiteApr 27, 2020
  2. push: unset PARSE_OPT_OPTARG for --recurse-submodulesDenton Liu, Apr 27, 2020
  3. Jeff KingApr 27, 2020
  4. Junio C HamanoApr 27, 2020
  5. Use OPT_CALLBACK and OPT_CALLBACK_FDenton Liu, Apr 28, 2020
  6. Jeff KingApr 28, 2020
  7. Junio C HamanoApr 28, 2020
  8. Junio C HamanoApr 28, 2020
  9. Denton LiuApr 28, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.