From: Denton Liu Date: Tue, 28 Apr 2020 22:59:08 GMT Subject: Re: [PATCH] push: unset PARSE_OPT_OPTARG for --recurse-submodules Message-ID: <20200428225908.GA2570028@generichostname> In-Reply-To: Hi Junio, On Tue, Apr 28, 2020 at 10:51:56AM -0700, Junio C Hamano wrote: > Here is what I am going to queue for this fix; hopefully it can be > cherry-picked by folks who maintain older versions of Git for > distros and in-house use. > > The other "huge" patch has also been adjusted by dropping the first > hunk on builtin/push.c from it, and then resurrecting the part to > use OPT_CALLBACK_F() for compare-and-swap (which happened to be in > the same hunk). Thanks, that approach makes sense to me. I looked at both patches that you have queued and they look good. -Denton