Re: [PATCH v2 3/3] fetch-pack: in protocol v2, reset in_vain upon ACK
Show 14 quoted lines
> In the function process_acks() in fetch-pack.c, the variable
> received_ack is meant to track that an ACK was received, but it was
> never set. This results in negotiation terminating prematurely through
> the in_vain counter, when the counter should have been reset upon every
> ACK.
>
> Therefore, reset the in_vain counter upon every ACK.
>
> Helped-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
> ---
> fetch-pack.c | 1 +
> t/t5500-fetch-pack.sh | 30 ++++++++++++++++++++++++++++++
> 2 files changed, 31 insertions(+)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.