Re: [PATCH] t5500: count objects through stderr, not trace

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 13, 2020, 14:45 UTC
Message-ID: <nycvar.QRO.7.76.6.2010131644310.50@tvgsbejvaqbjf.bet>
In-Reply-To: <20200506220741.71021-1-jonathantanmy@google.com>

Hi Jonathan,

On Wed, 6 May 2020, Jonathan Tan wrote:

Show 14 quoted lines

> In two tests introduced by 4fa3f00abb ("fetch-pack: in protocol v2,
> in_vain only after ACK", 2020-04-28) and 2f0a093dd6 ("fetch-pack: in
> protocol v2, reset in_vain upon ACK", 2020-04-28), the count of objects
> downloaded is checked by grepping for a specific message in the packet
> trace. However, this is flaky as that specific message may be delivered
> over 2 or more packet lines.
>
> Instead, grep over stderr, just like the "fetch creating new shallow
> root" test in the same file.
>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
> ---
> Thanks, Dscho. The commits introducing the flakiness have made it to
> master, so this commit is on master.

Sorry for the blast from the past. Apparently, even with this fix, the first test is still flaky.

I submitted a patch to work around the bug via https://github.com/gitgitgadget/git/pull/753; Please review when you have some time.

Thanks, Dscho