From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 28 Apr 2020 00:55:09 GMT
Subject: Re: [PATCH v2 3/3] fetch-pack: in protocol v2, reset in_vain upon ACK
Message-ID: <20200428005509.GG36078@google.com>
In-Reply-To: <e89646cb9ab1164d866ba9747575cab9199e3f62.1588031728.git.jonathantanmy@google.com>

Jonathan Tan wrote:

> In the function process_acks() in fetch-pack.c, the variable
> received_ack is meant to track that an ACK was received, but it was
> never set. This results in negotiation terminating prematurely through
> the in_vain counter, when the counter should have been reset upon every
> ACK.
>
> Therefore, reset the in_vain counter upon every ACK.
>
> Helped-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
> ---
>  fetch-pack.c          |  1 +
>  t/t5500-fetch-pack.sh | 30 ++++++++++++++++++++++++++++++
>  2 files changed, 31 insertions(+)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.