git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Compilation errors in git.pu/refs/reftable-backend.c

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Apr 27, 2020, 13:13 UTC
Message-ID
<20200427131312.GB61348@Carlos-MBP>
In-Reply-To
<CAFQ2z_O7z2prvnE+v-0nzC3=2mmUBHgFVF+iRqRn-7QyRQxOqg@mail.gmail.com>
On Mon, Apr 27, 2020 at 02:05:12PM +0200, Han-Wen Nienhuys wrote:
> 
> I don't understand why Git doesn't enforce this, though.  Couldn't
> -Wdeclaration-after-statement be added to the Makefile if the compiler
> supported it?

not sure if that flag will catch it, but from what I recall, that specific feature was only available in C99 while git's codebase targets C89 (need to build with --std=gnu89 as some GNU extensions are already needed).

see the "For C programs" section in Documentation/CodingGuidelines for details.

Carlo
Previous: Jeff KingNext: brian m. carlson
Message 4 of 5 in “Compilation errors in git.pu/refs/reftable-backend.c”
  1. Torsten BögershausenApr 27, 2020
  2. Han-Wen NienhuysApr 27, 2020
  3. Jeff KingApr 27, 2020
  4. Carlo Marcelo Arenas BelónApr 27, 2020
  5. brian m. carlsonApr 27, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.