git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Compilation errors in git.pu/refs/reftable-backend.c

From
Torsten Bögershausen <tboegi@web.de>
Date
Apr 27, 2020, 04:34 UTC
Message-ID
<575af27b-3823-2db5-ad3b-3c6cd7a95faa@web.de>

Folks, after the integration of the reftable branch: Merge branch 'hn/reftable' into pu

My historic (?) compiler stumbles over this code here:
refs/reftable-backend.c
   for (int i = 0; i < transaction->nr; i++) {

So I think we could easily avoid the (for int i) construction. The other observation could be, why we use an "int", when "nr" is defined as a size_t ?

struct ref_transaction {
	struct ref_store *ref_store;
	struct ref_update **updates;
	size_t alloc;
	size_t nr;
	enum ref_transaction_state state;
	void *backend_data;
};
Thanks for working on Git
Next: Han-Wen Nienhuys
Message 1 of 5 in “Compilation errors in git.pu/refs/reftable-backend.c”
  1. Torsten BögershausenApr 27, 2020
  2. Han-Wen NienhuysApr 27, 2020
  3. Jeff KingApr 27, 2020
  4. Carlo Marcelo Arenas BelónApr 27, 2020
  5. brian m. carlsonApr 27, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.