From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: Mon, 27 Apr 2020 13:13:12 GMT
Subject: Re: Compilation errors in git.pu/refs/reftable-backend.c
Message-ID: <20200427131312.GB61348@Carlos-MBP>
In-Reply-To: <CAFQ2z_O7z2prvnE+v-0nzC3=2mmUBHgFVF+iRqRn-7QyRQxOqg@mail.gmail.com>

On Mon, Apr 27, 2020 at 02:05:12PM +0200, Han-Wen Nienhuys wrote:
> 
> I don't understand why Git doesn't enforce this, though.  Couldn't
> -Wdeclaration-after-statement be added to the Makefile if the compiler
> supported it?

not sure if that flag will catch it, but from what I recall, that
specific feature was only available in C99 while git's codebase
targets C89 (need to build with --std=gnu89 as some GNU extensions
are already needed).

see the "For C programs" section in Documentation/CodingGuidelines for
details.

Carlo