git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] test-bloom: fix some whitespace issues

From
Jeff King <peff@peff.net>
Date
Apr 23, 2020, 21:04 UTC
Message-ID
<20200423210409.GB1635761@coredump.intra.peff.net>
In-Reply-To
<20200423210155.GA46862@syl.local>
On Thu, Apr 23, 2020 at 03:01:55PM -0600, Taylor Blau wrote:
Show 22 quoted lines
> On Thu, Apr 23, 2020 at 04:59:07PM -0400, Jeff King wrote:
> > Signed-off-by: Jeff King <peff@peff.net>
> > ---
> >  t/helper/test-bloom.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c
> > index ce412664ba..f9c0ce2bae 100644
> > --- a/t/helper/test-bloom.c
> > +++ b/t/helper/test-bloom.c
> > @@ -27,7 +27,7 @@ static void print_bloom_filter(struct bloom_filter *filter) {
> >  	}
> >  	printf("Filter_Length:%d\n", (int)filter->len);
> >  	printf("Filter_Data:");
> > -	for (i = 0; i < filter->len; i++){
> > +	for (i = 0; i < filter->len; i++) {
> 
> Thanks for fixing the spacing, but I wonder if these braces should be
> here at all. Since the body is one line long, maybe this should just be:
> 
>   for (i = 0; i < filter->len; i++)
>     printf("%02x|", filter->data[i]);

I have to admit that I don't care either way, and I think we spend too much time quibbling about braces or not-braces. It was really the bad indentation that I cared about most.

-Peff
Previous: Taylor BlauNext: Jeff King
Message 4 of 11 in “minor fixups for gs/commit-graph-path-filter”
  1. 0/2 minor fixups for gs/commit-graph-path-filterJeff King, Apr 23, 2020
  2. 1/2 test-bloom: fix some whitespace issuesJeff King, Apr 23, 2020
  3. Taylor BlauApr 23, 2020
  4. Jeff KingApr 23, 2020
  5. 2/2 test-bloom: check that we have expected argumentsJeff King, Apr 23, 2020
  6. Taylor BlauApr 23, 2020
  7. Garima SinghApr 23, 2020
  8. Taylor BlauApr 24, 2020
  9. Junio C HamanoApr 24, 2020
  10. Danh DoanApr 24, 2020
  11. Jeff KingApr 24, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.